Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key errors on short names #76

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Fix key errors on short names #76

merged 1 commit into from
Nov 28, 2023

Conversation

initstring
Copy link
Owner

The new GraphQL API returns full names only, and some of them were breaking previous logic. This was raised here: #75 by @pwnf (thanks)!

This PR adds a check to discard single-word names before being mutated.

I think this fixes the problem.

@initstring
Copy link
Owner Author

I'm crossing my fingers and merging. This should fix the issue, but I'll help troubleshoot any new open issues.

@initstring initstring merged commit 31608d2 into master Nov 28, 2023
1 check passed
@pwnf
Copy link

pwnf commented Nov 28, 2023

Tested this morning without making any changes to my system from yesterday and this fix appears to be working. I am guessing there may have been a problem with the VPN I was using and or LinkedIn didn't like my continuous scraping.. Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants